Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nginx Ingress Controller on sky local up #3223

Merged
merged 24 commits into from
Apr 2, 2024
Merged

Nginx Ingress Controller on sky local up #3223

merged 24 commits into from
Apr 2, 2024

Conversation

shethhriday29
Copy link
Contributor

@shethhriday29 shethhriday29 commented Feb 24, 2024 •
edited
Loading

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@shethhriday29 shethhriday29 changed the title initial implementation Nginx Ingress Controller on sky local up Feb 24, 2024
@shethhriday29 shethhriday29 mentioned this pull request Feb 24, 2024
Closed
@shethhriday29 shethhriday29 marked this pull request as ready for review February 25, 2024 09:17
romilbhardwaj
romilbhardwaj reviewed Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shethhriday29! Took a quick look.

sky/utils/kubernetes/nginx-deploy.yaml Outdated Show resolved Hide resolved
sky/clouds/kubernetes.py Outdated Show resolved Hide resolved
sky/provision/kubernetes/network_utils.py Outdated Show resolved Hide resolved
romilbhardwaj
romilbhardwaj reviewed Mar 20, 2024
View reviewed changes
sky/cli.py Outdated Show resolved Hide resolved
romilbhardwaj
romilbhardwaj reviewed Mar 20, 2024
View reviewed changes
sky/cli.py Outdated Show resolved Hide resolved
sky/cli.py Outdated Show resolved Hide resolved
sky/cli.py Outdated Show resolved Hide resolved
romilbhardwaj
romilbhardwaj reviewed Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shethhriday29!

sky/utils/kubernetes/kind_port_config.py Outdated Show resolved Hide resolved
sky/utils/kubernetes/kind_port_config.py Outdated Show resolved Hide resolved
sky/utils/kubernetes/kind_port_config.py Outdated Show resolved Hide resolved
Sheth and others added 2 commits March 27, 2024 11:54
romilbhardwaj
romilbhardwaj approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@romilbhardwaj romilbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shethhriday29! Pushed some minor nits. I have removed wait_for_nginx_ingress_controller_patch() since it did not seem necessary.

@romilbhardwaj romilbhardwaj merged commit 1c442e4 into skypilot-org:master Apr 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romilbhardwaj romilbhardwaj romilbhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shethhriday29 @romilbhardwaj