Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: minor updates to Mixtral example. #2882

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Docs: minor updates to Mixtral example. #2882

merged 1 commit into from
Dec 18, 2023

Conversation

concretevitamin
Copy link
Member

Makes news entry stand out by using the word "example".

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below): rendered
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Michaelvll
Michaelvll approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @concretevitamin! LGTM!

@concretevitamin concretevitamin merged commit d2106f4 into master Dec 18, 2023
19 checks passed
@concretevitamin concretevitamin deleted the docs-mixtral branch December 18, 2023 21:23
remyleone pushed a commit to remyleone/skypilot that referenced this pull request Dec 26, 2023
@concretevitamin @remyleone
Docs: minor updates to Mixtral example. (skypilot-org#2882)
6c76521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@concretevitamin @Michaelvll