New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Fix undefined var for serve #2811

Merged

Michaelvll merged 1 commit into master from undefined-var

Nov 21, 2023

Collaborator

Michaelvll commented Nov 21, 2023

sky status will raise unbounded local var when interrupted and goes into the following code path.

            if spot_jobs_query_interrupted:

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: bash tests/backward_comaptibility_tests.sh


          unused local var

7c99855

Michaelvll requested a review from cblmemo

November 21, 2023 23:16

cblmemo approved these changes

View reviewed changes

Michaelvll merged commit c0600bc into master

19 checks passed

Michaelvll deleted the undefined-var branch

November 21, 2023 23:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet