[k8s] Add OPEN_PORTS to unsupported features for kubernetes
#2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
approved these changes
Sep 21, 2023
|
I was wondering the same - I had formatted it to be different lines but pylint put them in the same line... |
IIRC I remembered that you need to add parentheses 🤧some strange pylint behaviour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently do not support opening ports on Kubernetes clusters. However, it is still picked by the optimizer as a candidate cloud because
CloudImplementationFeatures.OPEN_PORTSis not excluded in Kubernetes. This PR fixes that.Tested (run the relevant ones):
bash format.shsky launch -c <yaml_with_ports>, it excludes Kubernetes now