-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Better logging message for operators on the clusters terminated manually in the cloud #2389
Conversation
Nice @Michaelvll! QQ: does this cover all ops that auto refresh, e.g., |
Yes, it works for all the operators with the auto refresh. One thing to note is that it only works for the cluster with autostop/down setup or the spot cluster, as the normal cluster will not trigger the refresh. If a normal cluster is terminated in the console manually, the skypilot will still try to ssh into it and timeout after a while. |
…or-cluster-terminated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @Michaelvll!
One potential issue -- I had two clusters,
A multi-cluster command like |
Co-authored-by: Zongheng Yang <zongheng.y@gmail.com>
Thanks for catching this @concretevitamin! We previously forgot to catch the |
Fixes #2298.
Note this only works for the spot clusters or the clusters with autostop/down setup, as the status refresh will not be triggered for the operators on the normal clusters.
Previously:
Now:
Tested (run the relevant ones):
bash format.sh
sky launch -c test-warning-spot --cpus 2 --cloud gcp --use-spot
sky logs test-warning-spot
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh