Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Avoid signal when sky.launch is not executed in the main thread #2252

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

Michaelvll
Copy link
Collaborator

Fixes #2182

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review July 16, 2023 23:28
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @Michaelvll!

sky/backends/cloud_vm_ray_backend.py Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 677b2e8 into master Jul 17, 2023
@Michaelvll Michaelvll deleted the no-signal-handling branch July 17, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Get rid of signal handling
2 participants