[Storage] gsutil rsync failing to sync source with dangling symlink #2165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2147, which is initially raised by #2127
aws s3 sync
is a command ran to sync Sky Storages set withs3
/r2
storages. When the command sees a dangling symlink, it simply ignores and continue to sync other contents. However,gsutil rsync
, which is used to setgcs
, does not support this and fails early. In order to have consistent behavior betweengcs
ands3
/r2
storages, I add an additional flag to the command to ignore all the symlinks in the source. Adding-e
is the solution gsutil team provides to resolve dangling symlink issue. Also, as Sky Storage does not support symlinks, this is a suitable solution.Tested (run the relevant ones):
gsutil -m rsync -erx
to sync src with dangling symlink togcs
pytest tests/test_smoke.py::TestStorageWithCredentials
pytest tests/test_smoke.py::test_gcp_storage_mounts