Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Fix redundant disk tier information when default tier is used #2156

Merged
merged 2 commits into from
Jul 1, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Jun 30, 2023

Currently, Azure clusters launched without disk_tier specified will have a disk_tier in its Resources in the sky status command. This PR get rid of the redundant information.

$ sky launch --cloud azure
Clusters
NAME                          LAUNCHED        RESOURCES                                    STATUS   AUTOSTOP  COMMAND                         
cluster-name                  a few secs ago  1x Azure(Standard_D8s_v5, disk_tier=medium)  UP       -         sky launch --cloud azure ...   

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @cblmemo! LGTM. Just a small comment for readability.

sky/clouds/azure.py Outdated Show resolved Hide resolved
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
@Michaelvll Michaelvll merged commit 5402440 into skypilot-org:master Jul 1, 2023
@cblmemo cblmemo deleted the azure_disk_tier_ux branch July 12, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants