Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Support launching a new cluster from an existing cluster's disk #2098

Merged
merged 37 commits into from
Jun 28, 2023
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f447e0f
wip
Michaelvll Jun 15, 2023
419a002
delete the correct image_id
Michaelvll Jun 16, 2023
38d4693
not support migrate to existing cluster
Michaelvll Jun 16, 2023
5f003ee
Add run and retry
Michaelvll Jun 17, 2023
3360d34
Remove image after cluster is removed
Michaelvll Jun 17, 2023
c12fda0
make clone available for GCP
Michaelvll Jun 18, 2023
5c2c3db
fix image deletion
Michaelvll Jun 18, 2023
9cd39de
add permission docs
Michaelvll Jun 18, 2023
8625d7f
add permissions for the cloning in GCP
Michaelvll Jun 18, 2023
9c2b965
rename the feature
Michaelvll Jun 19, 2023
9091d92
format
Michaelvll Jun 19, 2023
b8f2c88
Address comments
Michaelvll Jun 23, 2023
14a3a99
format
Michaelvll Jun 23, 2023
2b1e2be
format
Michaelvll Jun 23, 2023
6df687d
only delete image when termination happens
Michaelvll Jun 24, 2023
ce6bf86
fix
Michaelvll Jun 25, 2023
cf0f066
Merge branch 'master' of github.com:skypilot-org/skypilot into clone-…
Michaelvll Jun 26, 2023
2651b18
address comments
Michaelvll Jun 27, 2023
f3776f7
Merge branch 'master' of github.com:skypilot-org/skypilot into clone-…
Michaelvll Jun 27, 2023
f1c98f7
Update sky/resources.py
Michaelvll Jun 27, 2023
4a778d9
fix docs
Michaelvll Jun 27, 2023
20e7da5
Merge branch 'clone-disk-from' of github.com:skypilot-org/skypilot in…
Michaelvll Jun 27, 2023
30205fd
comment
Michaelvll Jun 27, 2023
4427e47
address
Michaelvll Jun 27, 2023
e8f2bd6
Update sky/backends/backend_utils.py
Michaelvll Jun 27, 2023
2073c70
stack trace
Michaelvll Jun 27, 2023
b549691
Merge branch 'clone-disk-from' of github.com:skypilot-org/skypilot in…
Michaelvll Jun 27, 2023
8b2a94a
Merge branch 'master' of github.com:skypilot-org/skypilot into clone-…
Michaelvll Jun 27, 2023
3514029
doc numerating
Michaelvll Jun 27, 2023
8d9baa3
revert unnecessary changes
Michaelvll Jun 27, 2023
b5276bd
add smoke tests
Michaelvll Jun 27, 2023
254de30
fix test
Michaelvll Jun 27, 2023
e1e53e7
longer timeout
Michaelvll Jun 28, 2023
7b85601
sleep before image creation
Michaelvll Jun 28, 2023
ee59b10
longer wait time
Michaelvll Jun 28, 2023
4954fcb
longer wiat time
Michaelvll Jun 28, 2023
f6c77a5
fix azure test
Michaelvll Jun 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add smoke tests
  • Loading branch information
Michaelvll committed Jun 27, 2023
commit b5276bdf370dd5efb75a44aacd0a326bdbcd35e1
38 changes: 38 additions & 0 deletions tests/test_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,44 @@ def test_gcp_image_id_dict_zone():
run_one_test(test)


@pytest.mark.aws
def test_clone_disk_aws():
name = _get_cluster_name()
test = Test(
'clone_disk_aws',
[
f'sky launch -y -c {name} --cloud aws --region us-east-2 --retry-until-up "echo hello > ~/user_file.txt"',
f'sky launch --clone-disk-from {name} -y -c {name}-clone && exit 1 || true',
f'sky stop {name} -y',
f'sky launch --clone-disk-from {name} -y -c {name}-clone --region us-west-2 "cat ~/user_file.txt | grep hello"',
f'sky launch --clone-disk-from {name} -y -c {name}-clone-2 --region us-east-2 "cat ~/user_file.txt | grep hello"',
f'sky logs {name}-clone 1 --status',
f'sky logs {name}-clone-2 1 --status',
],
f'sky down -y {name} {name}-clone {name}-clone-2',
)
run_one_test(test)


@pytest.mark.gcp
def test_clone_disk_gcp():
name = _get_cluster_name()
test = Test(
'clone_disk_gcp',
[
f'sky launch -y -c {name} --cloud gcp --zone us-east1-b --retry-until-up "echo hello > ~/user_file.txt"',
f'sky launch --clone-disk-from {name} -y -c {name}-clone && exit 1 || true',
f'sky stop {name} -y',
f'sky launch --clone-disk-from {name} -y -c {name}-clone --zone us-central1-a "cat ~/user_file.txt | grep hello"',
f'sky launch --clone-disk-from {name} -y -c {name}-clone-2 --zone us-east1-b "cat ~/user_file.txt | grep hello"',
f'sky logs {name}-clone 1 --status',
f'sky logs {name}-clone-2 1 --status',
],
f'sky down -y {name} {name}-clone {name}-clone-2',
)
run_one_test(test)


@pytest.mark.aws
def test_image_no_conda():
name = _get_cluster_name()
Expand Down