Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Make the identity loading more robust #2033

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

Michaelvll
Copy link
Collaborator

This is to avoid the newlines in the identity string to affect the identity comparison to make the identity checking more robust. Try to fix #2032

Tested (run the relevant ones):

  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll
Copy link
Collaborator Author

Michaelvll commented Jul 11, 2023

I also met the problem in #2032 for a cluster I stopped long time ago, and this PR solved it. We should get this merged.

sky down test-*                                                     
Terminating 3 clusters: test-tqa. Proceed? [Y/n]: 
'test-tqa' (GCP) is owned by account ['zhwu@berkeley.edu [project_id=skypilot-xxx]'], but the activated account is ['zhwu@berkeley.edu\n [project_id=skypilot-xxx]'].

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I haven't encountered this issue, the code looks good to me 🫡

@Michaelvll Michaelvll merged commit e3a36b6 into master Jul 11, 2023
@Michaelvll Michaelvll deleted the robustify-identity-for-gcp branch July 11, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterOwnerIdentityMismatchError for the same user
2 participants