Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autodown] Better logging for sky status -r for autodown cluster #1254

Merged
merged 9 commits into from
Oct 15, 2022

Conversation

Michaelvll
Copy link
Collaborator

As mentioned by @concretevitamin, the current logging. for sky status -r is a bit scary, when the cluster with autodown is terminated. This PR handles the logging for the clusters with autodown differently against the normal clusters.

The new logging for the clusters with autodown:

sky status -r                                                                                                                                          ✈ ✱
I 10-14 13:17:38 backend_utils.py:1819] The following cluster was autodowned and removed from the cluster table: test-autodown
NAME             LAUNCHED  RESOURCES             STATUS  AUTOSTOP  COMMAND                    
smoke-test-zhwu  1 hr ago  1x GCP(n1-highmem-8)  UP      -         sky start smoke-test-zhwu 

Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Michaelvll! LGTM.

sky/cli.py Outdated Show resolved Hide resolved
sky/backends/backend_utils.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit f29da80 into master Oct 15, 2022
@Michaelvll Michaelvll deleted the autodown-log branch October 15, 2022 05:37
ewzeng pushed a commit to ewzeng/skypilot that referenced this pull request Oct 24, 2022
…kypilot-org#1254)

* Special logging for autodown cluster

* UX fix

* ux fix

* fix refreshing

* fix logging

* format

* fix autodown test

* Fix color

* Fix passive verb
ewzeng pushed a commit to ewzeng/skypilot that referenced this pull request Oct 24, 2022
…kypilot-org#1254)

* Special logging for autodown cluster

* UX fix

* ux fix

* fix refreshing

* fix logging

* format

* fix autodown test

* Fix color

* Fix passive verb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants