-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Refactor storage and fix data transfer service #1239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @Michaelvll!
response = storagetransfer.transferJobs().create( | ||
body=transfer_job).execute() | ||
operation = storagetransfer.transferJobs().run(jobName=response['name'], | ||
body={ | ||
'projectId': project_id | ||
}).execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious - are there any benefits other than readability to calling transferJobs().create()
followed by transferJobs().run()
instead of setting the schedule
field to current time and only calling transferJobs().create()
like we had before?
(Just to be clear, I prefer the former as we have now, but curious if there's some other reason to do it this way)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason for using the current interactive way to start the job is that we can get the name of the operation
for the run().execute()
(this is different from the name of the submitted TransferJob
, in the response
). With the name, we don't have to list all the running transfering jobs and find out the correct operation name that is scheduled by the cloud in L98 below. Also, since we will only run the TransferJob
once and in a blocking manner, I feel like having a schedule
field in the specification can be a bit misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks for fixing this!
…g#1239) * Refactor storage and fix data transfer service * fix UX for the data transfer * UX fixes * Address comments
…g#1239) * Refactor storage and fix data transfer service * fix UX for the data transfer * UX fixes * Address comments
Adopt changes for storage from #1152.
Tested:
tests/run_smoke_tests.sh TestStorageWithCredentials