disk_tier support

skypilot-org · Apr 23, 2023 · e6763b0 · e6763b0
1 parent dcb8442
commit e6763b0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/sky/clouds/ibm.py b/sky/clouds/ibm.py
@@ -235,9 +235,11 @@ def get_accelerators_from_instance_type(
     def get_default_instance_type(
             cls,
             cpus: Optional[str] = None,
-            memory: Optional[str] = None) -> Optional[str]:
+            memory: Optional[str] = None,
+            disk_tier: Optional[str] = None) -> Optional[str]:
         return service_catalog.get_default_instance_type(cpus=cpus,
                                                          memory=memory,
+                                                         disk_tier=disk_tier,
                                                          clouds='ibm')
 
     def get_feasible_launchable_resources(self,
@@ -275,7 +277,9 @@ def _make(instance_list):
         if accelerators is None:
             # Return a default instance type with the given number of vCPUs.
             default_instance_type = IBM.get_default_instance_type(
-                cpus=resources.cpus, memory=resources.memory)
+                cpus=resources.cpus,
+                memory=resources.memory,
+                disk_tier=resources.disk_tier)
             if default_instance_type is None:
                 return ([], [])
             else:
@@ -390,6 +394,11 @@ def check_credentials(cls) -> Tuple[bool, Optional[str]]:
         except Exception as e:
             return (False, f'{str(e)}' + help_str)
 
+    @classmethod
+    def check_disk_tier_enabled(cls, instance_type: str,
+                                disk_tier: str) -> None:
+        del instance_type, disk_tier  # unused
+
     def get_credential_file_mounts(self) -> Dict[str, str]:
         """Returns a {remote:local} credential path mapping
          written to the cluster's file_mounts segment

diff --git a/sky/clouds/service_catalog/ibm_catalog.py b/sky/clouds/service_catalog/ibm_catalog.py
@@ -95,7 +95,9 @@ def list_accelerators(
 
 
 def get_default_instance_type(cpus: Optional[str] = None,
-                              memory: Optional[str] = None) -> Optional[str]:
+                              memory: Optional[str] = None,
+                              disk_tier: Optional[str] = None) -> Optional[str]:
+    del disk_tier  # unused
     if cpus is None and memory is None:
         cpus = f'{_DEFAULT_NUM_VCPUS}+'