Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous things #1242

Merged
merged 8 commits into from
Aug 27, 2021
Merged

Miscellaneous things #1242

merged 8 commits into from
Aug 27, 2021

Conversation

ThexXTURBOXx
Copy link
Contributor

Description

  • Update Gradle for LGTM
  • Update dependencies in general
  • Fix tests for Windows users with a space in their username
  • Cleanup Gradle files
  • Fix Jitpack build by adding the maven-publish plugin
  • Fix calls to deprecated methods

@skylot
Copy link
Owner

skylot commented Aug 27, 2021

@ThexXTURBOXx before next PR please read contributing guide, because as stated in first line:

Please don't submit any code style fixes, dependencies updates or other changes which are not fixing any issues.

I will not accept changes which are not necessary.
So here I reverted:

  • a deprecation fixes - because this is not a correct way to resolve them. These deprecated methods is just a quick hack to glue old code with a new approach, so here should be a big refactoring to fix them.
  • imports in gradle file - I am not sure about this one, but these fullname classes used intentionally, check PR fix: Workaround for IntelliJ bug on import line in build.gradle #766.
  • I leave dependency updates for now, but please don't submit them again :)

Anyway, thanks for other changes 👍🏽

@skylot skylot merged commit f681c89 into skylot:master Aug 27, 2021
@ThexXTURBOXx
Copy link
Contributor Author

I'm sorry, I've read the contribution guideline only after I changed the files.
Thank you for accepting this PR anyways! :)
For the future, I know what to do :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants