support translatedContent test on leetcode-cn.com #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skygragon
reviewed
May 16, 2018
| @@ -137,6 +137,7 @@ plugin.getProblem = function(problem, cb) { | |||
| ' sampleTestCase', | |||
| ' enableRunCode', | |||
| ' metaData', | |||
| ' translatedContent', | |||
There was a problem hiding this comment.
Thanks @EINDEX!
I assume that this new field would work for both leetcode.com and leetcode-cn.com?
There was a problem hiding this comment.
if the problems doesn't have chinese in leetcode-cn.com like this sum-of-distances-in-tree. The tranlatedContent filed is null.
skygragon
reviewed
May 16, 2018
| if (!q.translatedContent) { | ||
| problem.desc = he.decode(cheerio.load(q.content).root().text()); | ||
| }else{ | ||
| problem.desc = he.decode(cheerio.load(q.translatedContent).root().text()); |
There was a problem hiding this comment.
could combine into single line like:
problem.desc = he.decode(cheerio.load(q.translatedContent || q.content).root().text());
Assume that q.translatedContent would be null if talking with leetcode.com.
15cm
pushed a commit
to 15cm/leetcode-cli
that referenced
this pull request
Jun 13, 2018
support translatedContent test on leetcode-cn.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93