Skip to content

SK-2173 fix card number regex #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raushan-skyflow merged 3 commits into from
Jul 17, 2025
Merged

SK-2173 fix card number regex #111

raushan-skyflow merged 3 commits into from
Jul 17, 2025

Conversation

@raushan-skyflow
Copy link

@raushan-skyflow raushan-skyflow commented Jul 16, 2025 •
edited
Loading

Why

  • BIN lookup was failing when the card number was formatted with hyphens (e.g., 4111-1111-1111-1111) in the CardNumberElement.

Outcome:

  • Updated the logic to handle both space-separated and hyphen-separated card number formats consistently.
  • BIN lookup now works seamlessly with both space (4111 1111 1111 1111) and hyphen (4111-1111-1111-1111) formats in the CardNumberElement.

Testing:

  • Locally
  • Added unit test

@raushan-skyflow raushan-skyflow merged commit 40c7b7d into release/25.6.1 Jul 17, 2025
2 checks passed
saileshwar-skyflow added a commit that referenced this pull request Dec 23, 2025
@saileshwar-skyflow
SK-2050: Public release - Add Set Token in Reveal Element (#118)
1ca624f 
* SK-2126 insert unformatted card number to vault (#107)

* SK-2173 support input formatting in reveal elements (#110)

* SK-2173 fix card number regex (#111)

* SK-2173 revert unformatted card no insertion to vault (#112)

* SK-2167 fix critical vulnerabilities (#113)

* SK-2050: set tokens in reveal elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyflow-vivek skyflow-vivek skyflow-vivek approved these changes

@saileshwar-skyflow saileshwar-skyflow saileshwar-skyflow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raushan-skyflow @skyflow-vivek @saileshwar-skyflow