Skip to content

SK-1904 add errorFromClient in error details#190

Merged
skyflow-shravan merged 1 commit intov2from
SK-1904
Feb 28, 2025
Merged

SK-1904 add errorFromClient in error details#190
skyflow-shravan merged 1 commit intov2from
SK-1904

Conversation

@skyflow-shravan
Copy link
Contributor

@skyflow-shravan skyflow-shravan commented Feb 26, 2025

This PR addresses feedback as well as customer request for invoke connections.

Why

  • When invoke connection request fails, the SDK throws an error with relevant details received from the API.
  • However, the customer is unable to debug whether error occurred on their end or third-party end based on given info.

Goal

  • Customers should be easily able to debug whether an error occurred on their end or third-party end
  • Improved error response structure to help customers with their problem

Testing

  • The changed were tested manually and unit tests are added

@skyflow-shravan skyflow-shravan merged commit 7f6e1fb into v2 Feb 28, 2025
2 checks passed
@skyflow-shravan skyflow-shravan deleted the SK-1904 branch June 18, 2025 09:01
skyflow-shravan added a commit that referenced this pull request Oct 15, 2025
@skyflow-shravan @amith-skyflow
@saileshwar-skyflow @skyflow-vivek @raushan-skyflow
SK-2341 update main branch with SDK v2 (#254)
a22a7c2 
* SK-1621: node sdk v2 (#181)

* SK-1863: Added section for migration from v1 to v2 in readme (#183)

* SK-1895 update readme for node sdk v2 (#186)

* SK-1895 update readme for sdk v2

* SK-1895 update readme for sdk v2

* SK-1895 update readme with sdk v2 changes

* SK-1895 update README with logging steps

* SK-1895 add response type for each response

* SK-1895 add response type for each response

* SK-1904 add errorFromClient in error details (#190)

* SK-2003: update readme (#196)

Co-authored-by: “amith-skyflow” <“amit@skyflow.com”>

* SK-1927 Update dependencies to latest stable versions

* SK-1757: Detect Support in Node SDK. (#212)

* SK-2048: Implement public interfaces for detect

* SK-2069 insert continue on error sample (#213)

* SK-2115 rebase beta release branch with main (#226)

* SK-2028: Beta Release for Node SDK v2 with Fern generated code. (#205)

* SK-1912: added fern generated code (#194)

* [AUTOMATED] Release - 2.0.0-beta.4

* SK-2048: Beta Release for Node SDK v2 with Detect public interfaces (#209)

* SK-2048: Implement public interface for detect

* [AUTOMATED] Release - 2.0.0-beta.5

* SK-2048: readme and samples for detect interfaces (#210)

* SK-2048:  Fix detect test cases. (#211)

* SK-2048: fix detect tests

* SK-2115 fix type gaps node sdk v2 (#224)

* SK-2056: add unions for credentials (#214)

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.81324cb

* SK-2116: update masking method enum to support blackbox masking method (#216)

* SK-2116: update masking method enum to support blackbox masking method

* SK-2116: fix the unit test

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.df7424a

* [DUMMY] commit to trigger the ci

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.ec4c6c2

* SK-2056: Update common-release.yml

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.7a24394

* SK-2119: remove console logs

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.b239cb3

* SK-2119: fix type gaps for error handling (#219)

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.28bbc38

* SK-2119: fix type gaps for error handling in service account

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.5be9b35

* SK-2119: fix http status

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.bc09a47

* SK-2119: remove any in service account

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.5c28afe

* SK-2115 fix type gaps (#222)

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.eae86a8

* SK-2119: fix handle error text

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.f902f67

* SK-2115 add null checks for deidentify text response

* SK-2115 make index range optional

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.4a8abd5

* SK-2115 add registry url to common release yml

* [AUTOMATED] Private Release 2.0.0-beta.5-dev.ac34566

---------

Co-authored-by: saileshwar-skyflow <156889717+saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: raushan-skyflow <raushan.gupta@skyflow.com>
Co-authored-by: raushan-skyflow <raushan-skyflow@users.noreply.github.com>
Co-authored-by: amith-skyflow <168510106+amith-skyflow@users.noreply.github.com>
Co-authored-by: amith-skyflow <amith-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar.bogam@skyflow.com>
Co-authored-by: skyflow-shravan <skyflow-shravan@users.noreply.github.com>

* [AUTOMATED] Release - 2.1.0-beta.1

* SK-2115 update version in package lock

---------

Co-authored-by: saileshwar-skyflow <156889717+saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: raushan-skyflow <raushan.gupta@skyflow.com>
Co-authored-by: raushan-skyflow <raushan-skyflow@users.noreply.github.com>
Co-authored-by: amith-skyflow <168510106+amith-skyflow@users.noreply.github.com>
Co-authored-by: amith-skyflow <amith-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar.bogam@skyflow.com>
Co-authored-by: skyflow-shravan <skyflow-shravan@users.noreply.github.com>

* SK-2101 readme changes after fixing type gaps (#227)

* SK-2101 readme changes after fixing type gaps

* SK-2101 update samples with proper types

* SK-2101 update samples with proper types

* SK-2101 fix content type key in invoke connection (#228)

* SK-2101 update credentials key in samples (#229)

* SK-2134 include file path and file object in request response (#230)

* Revert "SK-2134 include file path and file object in request response (#230)" (#231)

This reverts commit d9d8409.

* SK-2134 include file path and file object in request response

* SK-2134 include file path and file object in request response (#232)

* [AUTOMATED] Private Release 2.1.0-beta.1-dev.981921e

* SK-2134 include file path and file object in request response

* [AUTOMATED] Private Release 2.1.0-beta.1-dev.84fb37c

* SK-2134 throw error when both file and filepath are provided (#234)

* [AUTOMATED] Private Release 2.1.0-beta.1-dev.58e3761

* SK-2134 change error message and file input type

* SK-2134 change error message and file input type

* [AUTOMATED] Private Release 2.1.0-beta.1-dev.956e5c7

---------

Co-authored-by: skyflow-shravan <skyflow-shravan@users.noreply.github.com>

* SK-2137 samples and README for deidentify file changes (#236)

* SK-1729: Public Release V2 (#247)

* SK-1729: v2 public release

* [AUTOMATED] Release - 2.0.0

* SK-1729: v2 public release (#248)

* [AUTOMATED] Release - 2.0.0

* SK-2341 update release workflow

* SK-2341 remove code smells

* SK-2341 rename api key constants

* SK-2341 update README and samples

---------

Co-authored-by: amith-skyflow <168510106+amith-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <156889717+saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: “amith-skyflow” <“amit@skyflow.com”>
Co-authored-by: skyflow-vivek <vivek.jain@skyflow.com>
Co-authored-by: skyflow-vivek <121149418+skyflow-vivek@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar-skyflow@users.noreply.github.com>
Co-authored-by: raushan-skyflow <raushan.gupta@skyflow.com>
Co-authored-by: raushan-skyflow <raushan-skyflow@users.noreply.github.com>
Co-authored-by: amith-skyflow <amith-skyflow@users.noreply.github.com>
Co-authored-by: saileshwar-skyflow <saileshwar.bogam@skyflow.com>
Co-authored-by: skyflow-shravan <skyflow-shravan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skyflow-vivek skyflow-vivek skyflow-vivek approved these changes

@amith-skyflow amith-skyflow amith-skyflow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyflow-shravan @skyflow-vivek @amith-skyflow