aadarsh-st/SK-2521-Enhance content-type handling and add validation t…

[aadarsh-st]

Fixed below issues:

1. Add URL encoding in Utils and HttpUtility.
2. Update bearer token error message to indicate invalid or expired tokens.
3. Handle different request and response content types correctly and return request ID on errors.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[Copilot]

Pull request overview

This PR enhances content-type handling in the Skyflow SDK by supporting multiple content types (XML, plain text, HTML, form-encoded) beyond JSON, adds URL encoding for path/query parameters, and updates error messaging for bearer tokens.

Changes:

• Added URL encoding support in Utils.java and HttpUtility.java for path parameters, query parameters, and form-encoded data
• Updated bearer token error message to indicate "invalid or expired" instead of just "expired"
• Modified ConnectionController.java to handle both JSON and non-JSON request/response content types using a __raw_body__ wrapper
• Enhanced validation in Validations.java to support String request bodies and check for empty/whitespace-only strings
• Added comprehensive test coverage for new content-type handling across XML, HTML, plain text, and form-encoded formats

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
ConnectionControllerTests.java	Added tests for string request bodies with various content types (XML, HTML, plain text)
InvokeConnectionTests.java	Added validation tests for string bodies, empty/whitespace strings, and special characters in form-encoded data
HttpUtilityTests.java	Added tests for raw body handling, null request IDs, and URL encoding of special characters
ConnectionController.java	Modified to detect content type and handle both JSON and non-JSON payloads with raw body wrapping
Validations.java	Enhanced to validate String request bodies and detect empty/whitespace-only strings
Utils.java	Added URL encoding for path and query parameters with fallback handling
HttpUtility.java	Added raw body detection, conditional content-type setting, and URL encoding for form data
InfoLogs.java	Updated bearer token expiry message to include "invalid or expired"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

src/main/java/com/skyflow/vault/controller/ConnectionController.java:1

• The error message 'Server returned error' is generic and uninformative. Consider including the HTTP status code or more context about what went wrong, such as 'Server returned error with status code {httpCode}'.

package com.skyflow.vault.controller;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.