SK-2519: extract hard coded strings to constants and update linting r… #272
+372
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
|
|
||
| import com.skyflow.utils.Constants; | ||
|
|
||
| @SuppressWarnings("checkstyle:MultipleStringLiterals") |
Collaborator
There was a problem hiding this comment.
Why did we add SuppressWarnings annotation here ? What warnings are we suppressing ?
Collaborator
Author
There was a problem hiding this comment.
as the file constains strings, and checkstyle linter will catch them, so added SuppressWarnings to avoid it catching
| <consoleOutput>true</consoleOutput> | ||
|
|
||
| <excludes>**/generated/**</excludes> | ||
| <excludes>**/generated/**,**/logs/**</excludes> |
Collaborator
There was a problem hiding this comment.
Why are we excluding logs ?
Collaborator
Author
There was a problem hiding this comment.
as log constains strings, and checkstyle linter will catch them, so excluded logs to avoid it catching
saileshwar-skyflow
approved these changes
Feb 3, 2026
Devesh-Skyflow
approved these changes
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Following the Node SDK linting audit and refactor, this ticket focuses on applying the same linting standards and best practices across Java SDK v2.
The goal is to ensure consistent use of constants over hardcoded values across Java SDK v2, improving maintainability and readability.
Goal:
Update linting rules to discourage hardcoded literals where constants should be used.
Refactor existing code to replace hardcoded values with well-defined constants.