Skip to content

SK-1737 Fix inconsistencies in Java SDK #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skyflow-vivek merged 1 commit into from
Dec 10, 2024
Merged

SK-1737 Fix inconsistencies in Java SDK #145

skyflow-vivek merged 1 commit into from
Dec 10, 2024

Conversation

@skyflow-vivek
Copy link
Collaborator

@skyflow-vivek skyflow-vivek commented Dec 10, 2024

This PR includes changes to fix inconsistencies with respect to other server-side SDKs, some missing validation scenario along with additional unit tests.

Why

  • Java SDK v2 has some inconsistencies that needs to be addressed.
  • To ensure consistent behaviour across server-side SDKs.

Goal

  • Fewer inconsistencies w.r.t other server-side SDKs.
  • Consistent response structure for invoke connection response.

Testing

  • Manual testing for all vault API interfaces along with connections.
  • Additional unit tests for fixed inconsistencies.

@skyflow-vivek skyflow-vivek merged commit 8339ce7 into release/24.12.1 Dec 10, 2024
4 checks passed
@skyflow-shravan skyflow-shravan deleted the SK-1737-fix-inconcistencies-in-java-sdk branch June 18, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amith-skyflow amith-skyflow amith-skyflow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skyflow-vivek @amith-skyflow