SK-1802 Fix inconsistencies in SDK v2 #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix inconsistency between vault and connection client - Added unit tests for vault and connection clients
skyflow-vivek
force-pushed
the
SK-1802-fix-inconsistencies-in-sdk-v2
branch
from
a1b3476 to
ea8ae4c
Compare
amith-skyflow
approved these changes
Dec 9, 2024
skyflow-vivek
force-pushed
the
SK-1802-fix-inconsistencies-in-sdk-v2
branch
from
5175c27 to
e094aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes in the way we are parsing the responses of API requests. It also fixes few inconsistencies w.r.t other server-side SDKs along with few additional unit tests.
Why
Goal
Testing