fix: Pass through optional consumer settings when checking for offsets #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-glyde
reviewed
Apr 25, 2023
bcarter97
reviewed
Apr 26, 2023
| @@ -145,6 +148,30 @@ class TopicLoaderIntSpec extends IntegrationSpecBase { | |||
| } | |||
| } | |||
|
|
|||
| "Kafka consumer settings" should { | |||
| "Override default settings" in new TestContext { | |||
| override implicit lazy val system: ActorSystem = ActorSystem("test-actor-system") | |||
There was a problem hiding this comment.
I think the idea of the consumerSettings override is so that if the ActorSystem already contains Kafka settings they will be ignored. So it might be worth keeping the default ActorSystem that already contains things like bootstrap.servers and asserting the override is the one used
There was a problem hiding this comment.
Updated this to keep the default ActorSystem config. To prove the override config is being used we set bootstrapServers to something invalid to trigger an exception.
r-glyde
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to use the
kafka-topic-loaderto consume from multiple Kafka clusters. To do this we are providing an override forbootstrapServersin the optionalconsumerSettingsin theloadAndRunmethod (as opposed to loading from the defaultakka.conffile), but there are places in theTopicLoaderwhere these optional consumer settings are being ignored (logging/checking offsets).This PR will allow the topic loader to work with multiple Kafka clusters.