Adds a view method for getting current chi.
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Open to whatever changes to function/variable naming you all want. |
This change makes it so a contract with a `view` function can know what `chi` would be in this block. This is useful for contracts that have view functions that need to return values denominated in DAI when looking at DSR balances. An example use case for this is a token contract (DAI-GoUp) that wraps DAI held in DSR. The `balanceOf` function of such a contract (which is `view`) needs to be able to calculate the current balance of an account denominated in DAI. In order to do this, it must calculate what `chi` _would_ be if `drip` was called this block, but without actually calling `drip` (because that is not a view function).
Author
|
We could change this method to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so a contract with a
viewfunction can know whatchiwould be in this block. This is useful for contracts that have view functions that need to return values denominated in DAI when looking at DSR balances.An example use case for this is a token contract (DAI-GoUp) that wraps DAI held in DSR. The
balanceOffunction of such a contract (which isview) needs to be able to calculate the current balance of an account denominated in DAI. In order to do this, it must calculate whatchiwould be ifdripwas called this block, but without actually callingdrip(because that is not a view function).