Skip to content

give non-kube users info when system uninstall fails #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pwright wants to merge 2 commits into
base: main
Choose a base branch
from
Open

give non-kube users info when system uninstall fails #2358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce7636b
give non-kube users info when system uninstall fails
pwright Jan 19, 2026
383f4ad
Update internal/cmd/skupper/system/nonkube/system_uninstall.go
pwright Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/cmd/skupper/system/nonkube/system_uninstall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,16 @@ func (cmd *CmdSystemUninstall) Run() error {
return err
}

if len(entries) == 0 {
Copy link
Member

@nluaces nluaces Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is not printed when there are no namespaces to remove:

nluaces:skupper$ skupper system install 
Pulled system-controller image: quay.io/skupper/system-controller:v2-dev
Platform podman is now configured for Skupper
nluaces:skupper$ skupper system uninstall --force
System-controller has been removed
Platform podman infrastructure for Skupper is now uninstalled

Because in that directory there is an entry called controller.lock, I think it is better to check that there are no directories instead of entries, or just to remove that message.

fmt.Println("No namespaces found to remove")
}

for _, entry := range entries {
if entry.IsDir() {
runtimeDir := "namespaces/" + entry.Name() + "/runtime/"
_, err := os.ReadDir(path.Join(api.GetHostDataHome(), runtimeDir))
if err == nil {
fmt.Printf("Removing active site namespace \"%s\"\n", entry.Name())
err := cmd.TearDown(entry.Name())
if err != nil {
return fmt.Errorf("failed to remove site \"%s\": %s", entry.Name(), err)
Expand Down
12 changes: 11 additions & 1 deletion internal/nonkube/bootstrap/uninstall.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,17 @@ func CheckActiveSites() (bool, error) {
_, err := os.ReadDir(path.Join(api.GetHostDataHome(), runtimeDir))
if err == nil {
activeSites = true
fmt.Printf("site %s active\n", entry.Name())
siteName := ""
runtimeSiteStatePath := path.Join(api.GetHostNamespaceHome(entry.Name()), string(api.RuntimeSiteStatePath))
siteStateLoader := &common.FileSystemSiteStateLoader{Path: runtimeSiteStatePath}
if siteState, loadErr := siteStateLoader.Load(); loadErr == nil && siteState != nil && siteState.Site != nil {
siteName = siteState.Site.Name
}
if siteName != "" {
fmt.Printf("The %s site is active (namespace %s)\n", siteName, entry.Name())
} else {
fmt.Printf("The %s site is active\n", entry.Name())
}
}

}
Expand Down