-
Notifications
You must be signed in to change notification settings - Fork 86
Add a watcher for system input files #2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add a watcher for system input files #2334
Conversation
163082a to
853219d
Compare
fgiorgetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to include a message in the startup banner of the system controller, displaying the status of the autoreload definition.
Another thing I am missing here is the fact that if you delete a Site and/or all resources from a given namespace, the Teardown is not being executed.
fgiorgetti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is working great now.
One thing that is still missing is a log message indicating whether reload type is auto or manual as part of the startup banner.
| endpoint = "unix:///var/run/podman.sock" | ||
| if s.Platform == "docker" { | ||
| endpoint = "unix:///run/docker.sock" | ||
| endpoint = "unix:///var/run/docker.sock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the old value is still appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have double checked this using docker as platform and leaving unix:///run/docker.sock:
2026/02/09 16:15:26 ERROR Failed to bootstrap: failed to render site state: failed to create container client: Container engine is not available on provided endpoint - stat /run/docker.sock: no such file or directory component=input.resource.handler namespace=default
I think the problem is similar to podman platform, regarding where the container endpoint is mapped to the socket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that /var/run should work, as it is supposed to be just a lihk to /run, but I am wondering when did it change. Which version of docker do you have, Noe?
Anyway, if we want to change this, then there are several other locations in the repo that must be updated as well. If something has changed recently, then better changing it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docker version 29.2.1, build a5c7197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, if we want to change this, then there are several other locations in the repo that must be updated as well. If something has changed recently, then better changing it everywhere.
I agree. Should be changed everywhere as part of this pull request? I can also do it as part of another issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can do it here, at least all references will be using /var/run/docker.sock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fgiorgetti let me know if these commits work for you:
867d6ac
a90b119
I haven't done these changes in the implementations of install/uninstall commands, as they are not meant to be executed inside the container (same goes for bootstrap.sh and system_controller.sh).
dfeb6a6 to
dab70d7
Compare
sorry! fixed now. |
Implements #2333
Changes:
SKUPPER_SYSTEM_RELOAD_TYPEto "manual"skupper system installneeds to pass said env. variable to the system-controller pod.Additional information: