[BUG] Fix XGBoostLSS wrapper parameterization
#700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrov
requested review from
SaiRevanth25,
felipeangelimvieira and
fkiraly
as code owners
Member
Author
|
Current errors are due to the |
fkiraly
changed the title
XGBoostLSS wrapper parameterization
Collaborator
|
Thanks! I think we should merge #672 instead, to ensure the parameters are explicit. I also added a fix for the |
Collaborator
|
I will merge this - for the credits re the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
XGBoostLSShardcodes stabilization, response and loss params #670XGBoostLSSwrapper should expose the underlying XGBoost params #671