Skip to content
This repository was archived by the owner on Jul 17, 2023. It is now read-only.

Unexpected keyword argument 'user_agent'#36

Merged
skoudoro merged 2 commits intoskoudoro:masterfrom
rsoltys:master
Nov 15, 2021
Merged

Unexpected keyword argument 'user_agent'#36
skoudoro merged 2 commits intoskoudoro:masterfrom
rsoltys:master

Conversation

@rsoltys
Copy link
Contributor

@rsoltys rsoltys commented Nov 15, 2021

Recently, I noticed an issue regarding Subscriber: unexpected keyword argument 'user_agent'.
Mailerlite API has been changed, so I added new key to Subscriber.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #36 (9e1fc30) into master (5293d28) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files          11       11           
  Lines         509      509           
=======================================
  Hits          467      467           
  Misses         42       42           
Impacted Files Coverage Δ
mailerlite/constants.py 100.00% <ø> (ø)

@skoudoro
Copy link
Owner

Great! Thank you for doing that! I need to find a way / develop a test to check this kind of new parameter.

merging

@skoudoro skoudoro merged commit e1aa102 into skoudoro:master Nov 15, 2021
@alby-m
Copy link

alby-m commented Nov 16, 2021

Thanks for the fix! Do you plan to issue new version that will include this fix any time soon? 🙏 @skoudoro

@skoudoro
Copy link
Owner

I would like to add/fix some tests before releasing, so I will try asap @alby-m but I am quite busy this week. Worst case, it should be done by Monday.

@PhilBeaudoin
Copy link

Thanks for looking into this @skoudoro ! It broke something on my end too. Quite interested by the release! :)

@skoudoro
Copy link
Owner

skoudoro commented Nov 17, 2021

Ok, many requests so release done (v0.8.0) @PhilBeaudoin, @alby-m, @vitormorales.

Feel free to add a star to the project, it helps 😄!

pip install -U mailerlite-api-python

@skoudoro
Copy link
Owner

And thanks all for your feedback!

@alby-m
Copy link

alby-m commented Nov 22, 2021

Thanks a lot, much appreciated ⭐ @skoudoro

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants