Skip to content
This repository was archived by the owner on Jul 17, 2023. It is now read-only.

add campaign_name to Activity#29

Merged
skoudoro merged 5 commits intoskoudoro:masterfrom
rsoltys:master
Jun 23, 2021
Merged

add campaign_name to Activity#29
skoudoro merged 5 commits intoskoudoro:masterfrom
rsoltys:master

Conversation

@rsoltys
Copy link
Contributor

@rsoltys rsoltys commented Jun 23, 2021

No description provided.

@pep8speaks
Copy link

pep8speaks commented Jun 23, 2021

Hello @rsoltys! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-23 08:35:11 UTC

Copy link
Owner

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsoltys,

Looks good to me, Thank you for doing this!

Could you also address the pep8 issue above and update the test?

Thank you

@rsoltys
Copy link
Contributor Author

rsoltys commented Jun 23, 2021

Hi @skoudoro,

I've just resolved issue regarding pep8. I noticed and fixed another issue in Campaign, could you please have a look?
All tests are green in my environment. Hopefully, it is fine now.

Thanks

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #29 (6fe4c76) into master (c014751) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          11       11           
  Lines         502      502           
=======================================
  Hits          460      460           
  Misses         42       42           
Impacted Files Coverage Δ
mailerlite/campaign.py 93.10% <100.00%> (ø)
mailerlite/constants.py 100.00% <100.00%> (ø)

@skoudoro skoudoro linked an issue Jun 23, 2021 that may be closed by this pull request
@skoudoro skoudoro added the bug Something isn't working label Jun 23, 2021
Copy link
Owner

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I tested it locally and it is fine for me too.

Thank you again @rsoltys, merging!

@skoudoro skoudoro merged commit 17a777a into skoudoro:master Jun 23, 2021
@skoudoro
Copy link
Owner

PS: I will cut a release with this change tonight or tomorrow

@rsoltys
Copy link
Contributor Author

rsoltys commented Jun 23, 2021

Awesome! Thank you as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

campaign_name is missing in Activity

3 participants