Minor fix for LoggedOut view #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now in the logged out view the Logout button is replaced by the Login button.
skoruba
approved these changes
Oct 20, 2019
Comment on lines
+70
to
+73
| else | ||
| { | ||
| <a class="menu-item my-2 btn btn-outline-primary" asp-action="Login" asp-controller="Account" asp-route-returnUrl="~/" asp-route-forceLoginScreen="true">@Localizer["Login"]</a> | ||
| } |
There was a problem hiding this comment.
Here is missing localization for "Login" key. :-) Why do you use route "forceLoginScreen"? Thanks
There was a problem hiding this comment.
The parameter forceLoginScreen belongs to the Windows support feature, I must have mixed things up, sorry.
Its use is to present the login screen even when the automatic Windows login is configured. I thought that users should have a way of choosing a different account than their Windows one (for example to access as administrator), and I think that clicking the login button of the Identity Server top menu is a good way of achieving it without compromising the automation of the other workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the users log out, the Logout button was still visible and an empty name was displayed, because we are still in the same request where _signInManager.SignOutAsync has been called and User.Identity.IsAuthenticated still returns true.
Now in the LoggedOut view the Logout button is replaced by the Login button.