Fixed writing accesses that bypass manager classes #303
Conversation
|
@skoruba , I am also looking for this functionality to capture events. Can you approve the merge? |
|
Sure, please take a look at my comments - is it necessary to use |
|
I think answer is it depends -
https://blog.stephencleary.com/2017/03/aspnetcore-synchronization-context.html |
|
OK, but is it required in this case? :) |
|
I do not think Identity server Admin libraries being used outside Web API or Server side MVC. Hence, ConfigureAwait is unnecessary. |
|
I have same opinion. Can you please @gingters remove usage of |
| var userClaim = await DbContext.Set<TUserClaim>().Where(x => x.Id == claimId).SingleOrDefaultAsync(); | ||
|
|
||
| DbContext.UserClaims.Remove(userClaim); | ||
| await UserManager.RemoveClaimAsync(user, new Claim(userClaim.ClaimType, userClaim.ClaimValue)).ConfigureAwait(false); |
There was a problem hiding this comment.
@TomasHubelbauer - Is it required to use ConfigureAwait(false) here and a few lines bellow? :)
Thanks!
There was a problem hiding this comment.
@gingters - Why do you use ConfigureAwait(false)? :)
Thanks.
In our custom IdentityServer implementation, we need to create events for every change on the users and roles.
For that, we decorated the
UserStore<TUser>of the AspNetCore Identity model and create our events on every write access. The AspNetCore.IdentitiesUserManagerandRoleManagerboth use theIUserStoreandIRoleStorefor write access exclusively, so that is the only good place to intercept changes to the users and roles.In your
IIdentityRepositoryyou use the manager classes to create user claims and role claims, but for deleting these you bypass theUserManager/RoleManagerclasses and use theIdentityDbContextdirectly to deleteUserClaimsandRoleClaims.This pull request changes this to also use the manager classes (and thus internally the Store) to write these changes to the database, so that we are capable of intercepting them and creating the required events when a user or a role changes.