Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration from json file #231

Merged
merged 20 commits into from
Oct 5, 2019
Merged

Conversation

xmichaelx
Copy link
Contributor

@xmichaelx xmichaelx commented Mar 27, 2019

Configuration read from json file. What do you think? I'd like to remove hardcoded code in the next commit :)

Client secrets are hashed before being pumped into db.

@xmichaelx xmichaelx requested a review from skoruba March 27, 2019 13:22
@skoruba
Copy link
Owner

skoruba commented Apr 4, 2019

Great work, I will test it. 👍
Thank you

@xmichaelx
Copy link
Contributor Author

I'll add additional code for deserializing System.Security.Claims from Json, because by default they have trouble with that. So do not pull this just yet.

Copy link
Owner

@skoruba skoruba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, I've updated your PR with some other configuration properties especially regarding authentication middleware.

@skoruba skoruba merged commit d8f6d0a into dev Oct 5, 2019
@skoruba skoruba deleted the seeding-db-with-json-document branch October 5, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants