Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT - Removes sklearn-intelex and updates changelog #420

Merged
merged 4 commits into from
May 14, 2024

Conversation

lazarust
Copy link
Contributor

@lazarust lazarust commented May 5, 2024

Reference Issues/PRs

Brought up in #394

What does this implement/fix? Explain your changes.

Removes sklearn-intelex

Any other comments?

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a page in our documentation which uses this, and it's used in the API as well, those need to be removed as well.

@lazarust
Copy link
Contributor Author

lazarust commented May 8, 2024

@adrinjalali Sorry about that, everything should be removed now!

@lazarust lazarust changed the title Removes sklearn-intelex and updates changelog MNT - Removes sklearn-intelex and updates changelog May 8, 2024
docs/changes.rst Outdated Show resolved Hide resolved
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@adrinjalali
Copy link
Member

I think there's also a dead link here, the whole paragraph should be removed

- Using Intel(R) Extension for scikit-learn:
    :ref:`sphx_glr_auto_examples_plot_intelex.py` is an example of using
    Intel(R) Extension for scikit-learn to speed up inference of classical
    machine learning algorithms and how performance-optimized models work with
    Hugging Face Hub.

in examples.rst

@lazarust lazarust requested a review from adrinjalali May 14, 2024 00:56
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @lazarust

@adrinjalali adrinjalali merged commit 813a240 into skops-dev:main May 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants