Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Document compatibility across sklearn versions #290

Conversation

BenjaminBossan
Copy link
Collaborator

Resolves #270

Add a section to the persistence docs that cautions about using skops to load sklearn models saved with one version while using another version. Refers to sklearn docs on that issue.

Resolves skops-dev#270

Add a section to the persistence docs that cautions about using skops to
load sklearn models saved with one version while using another version.
Refers to sklearn docs on that issue.
@BenjaminBossan BenjaminBossan changed the title [skip ci] Document compatibility across versions Document compatibility across versions Feb 3, 2023
@BenjaminBossan BenjaminBossan changed the title Document compatibility across versions Document compatibility across sklearn versions Feb 3, 2023
@BenjaminBossan
Copy link
Collaborator Author

Generated documentation can be found here. Ready for review @skops-dev/maintainers

Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

docs/persistence.rst Outdated Show resolved Hide resolved
docs/persistence.rst Outdated Show resolved Hide resolved
BenjaminBossan and others added 2 commits February 27, 2023 17:55
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
@BenjaminBossan
Copy link
Collaborator Author

@adrinjalali I merged your suggestions.

@adrinjalali adrinjalali changed the title Document compatibility across sklearn versions DOC Document compatibility across sklearn versions Feb 28, 2023
@adrinjalali adrinjalali merged commit 69be7cb into skops-dev:main Feb 28, 2023
@BenjaminBossan BenjaminBossan deleted the DOC-persistence-compatbility-sklearn-versions branch February 28, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forward compatibility of sklearn models saved with skops.io
2 participants