Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Model card refactor to move plotting & table #163

Merged
merged 5 commits into from
Oct 5, 2022
Merged

MNT Model card refactor to move plotting & table #163

merged 5 commits into from
Oct 5, 2022

Conversation

merveenoyan
Copy link
Collaborator

Resolves #157.
I moved plot & hyperparameter table to _generate_card() to keep save() atomic, given it's already called during save(). Does it sound good?

BenjaminBossan
BenjaminBossan reviewed Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a comment that might simplify the code a bit, otherwise LGTM.

Regarding the testing, we could test exactly the case where card.model is reassigned, but I don't think it's strictly necessary.

skops/card/_model_card.py Outdated Show resolved Hide resolved
adrinjalali
adrinjalali reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

skops/card/_model_card.py Outdated Show resolved Hide resolved
@adrinjalali adrinjalali changed the title Model card refactor to move plotting & table MNT Model card refactor to move plotting & table Oct 5, 2022
@adrinjalali adrinjalali merged commit 8fe2577 into skops-dev:main Oct 5, 2022
@adrinjalali adrinjalali mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create hyperparameter table and model diagram during render
3 participants
@merveenoyan @adrinjalali @BenjaminBossan