Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take model as argument to generate the card #96

Closed
merveenoyan opened this issue Aug 11, 2022 · 3 comments
Closed

Take model as argument to generate the card #96

merveenoyan opened this issue Aug 11, 2022 · 3 comments
Labels
hacktoberfest Issues that are encouraged to be taken by hacktoberfest participants.

Comments

@merveenoyan
Copy link
Collaborator

About this comment in this PR. Currently model card generation takes an argument called model which actually is a model path. We need to take model as well as model path, we can warn the user if both of them are missing.
@adrinjalali
Copy link
Member

I don't think we need to change anything about the args, the model arg can take an estimator instance, or a path.

@merveenoyan merveenoyan added the hacktoberfest Issues that are encouraged to be taken by hacktoberfest participants. label Oct 4, 2022
@p-mishra1 p-mishra1 mentioned this issue Oct 5, 2022
Closed
@p-mishra1
Copy link
Contributor

@merveenoyan I created a PR regarding this #174 .

@p-mishra1 p-mishra1 mentioned this issue Oct 28, 2022
Merged
BenjaminBossan pushed a commit that referenced this issue Nov 23, 2022
@p-mishra1
load model from path/str to generate Card (#205)
757b940 
Solves #96

Add possibility to instantiate a model card with a model passed as str or Path.

The model will be loaded from disk if accessed. For now, the model is not cached,
so passing the loaded model is still recommended.
@BenjaminBossan
Copy link
Collaborator

Solved via #205

@BenjaminBossan BenjaminBossan mentioned this issue Dec 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Issues that are encouraged to be taken by hacktoberfest participants.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adrinjalali @BenjaminBossan @merveenoyan @p-mishra1