Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and integrate model cards from Hub library #155

Closed
BenjaminBossan opened this issue Sep 28, 2022 · 1 comment · Fixed by #162
Closed

Test and integrate model cards from Hub library #155

BenjaminBossan opened this issue Sep 28, 2022 · 1 comment · Fixed by #162

Comments

@BenjaminBossan
Copy link
Collaborator

With the new release of huggingface_hub (https://github.com/huggingface/huggingface_hub/releases/tag/v0.10.0), model cards have been completely integrated there and modelcards is deprecated.

From the skops side, we should ensure that everything works with the new hub version and write code to transition to using it instead of modelcards.
@adrinjalali
Copy link
Member

we can migrate to using modelcards from huggingface_hub, and move the dependency up. I think we can do it since we still don't have many users.

BenjaminBossan added a commit to BenjaminBossan/skops that referenced this issue Sep 30, 2022
@BenjaminBossan
Move to huggingface_hub v0.10
bf3c3ec 
Resolves skops-dev#155

There are two major changes accompanying this move:

- Model cards have now moved to the hub libary, modelcards is deprecated
- Some API changes around token => use_auth_token
@BenjaminBossan BenjaminBossan mentioned this issue Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MNT Move to huggingface_hub v0.10 BenjaminBossan/skops
2 participants
@adrinjalali @BenjaminBossan