Update: fixing bug raised around stanza model not having certain words in vocabulary, along with efforts to improve latency - #115
Open
AchintyaX wants to merge 11 commits into
Open
Update: fixing bug raised around stanza model not having certain words in vocabulary, along with efforts to improve latency #115AchintyaX wants to merge 11 commits into
AchintyaX wants to merge 11 commits into
Conversation
Contributor
Author
|
Sentry link for the bug |
… replacing with fuzzy search
Contributor
Author
|
Added fuzzy search, using |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 1921 1925 +4
=========================================
+ Hits 1921 1925 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AchintyaX
commented
Feb 15, 2022
| """ | ||
| value = value + str(word.text) + " " | ||
| if value != "": | ||
| matches = process.extract(value, entity_patterns) |
Contributor
Author
There was a problem hiding this comment.
Make it a flag to get all entities or 1 entity
AchintyaX
commented
Feb 15, 2022
AchintyaX
left a comment
AchintyaX
left a comment
Contributor
Author
There was a problem hiding this comment.
use pyinstrument for profiling the changes and speed gains
…e which was happening earlier
…and switched to extractOne method in fuzzy searching
…and switched to extractOne method in fuzzy searching, and updating type check Signed-off-by: Achintya Shankhdhar <achintyashankhdhar@gmail.com>
AchintyaX
force-pushed
the
list_search_bug_fix
branch
from
February 18, 2022 14:53
6534fb1 to
85fa241
Compare
…and switched to extractOne method in fuzzy searching, and updating type check, adding PatternList Signed-off-by: Achintya Shankhdhar <achintyashankhdhar@gmail.com>
AchintyaX
force-pushed
the
list_search_bug_fix
branch
from
February 18, 2022 15:00
85fa241 to
7bcd692
Compare
…and switched to extractOne method in fuzzy searching, and updating type check, adding PatternList
AchintyaX
force-pushed
the
list_search_bug_fix
branch
from
February 18, 2022 15:04
ebffdfa to
5f836e5
Compare
AchintyaX
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was found when testing in Oppo when users are saying something in Hindi but English ASR is used. certain words are out of vocabulary for the stanza model.
the PR is a error handling for this instance