Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #188
In general, I've been nudging Skip to prefer using the tools installed by Android Studio over Homebrew's tools, and this PR is one example of that.
In a UTM environment following my test plan in skiptools/skip#632 where we've only just installed Xcode, Android Studio, and Skip, Homebrew's ANDROID_HOME in
/opt/homebrew/share/android-commandlinetoolsonly contains one directory,cmdline-tools.cmdline-tools/latest/bincontainssdkmanagerandavdmanager, but noemulator/emulatorand noplatform-tools/adb.In this PR, we first try to find the emulator in ANDROID_HOME. If you've installed Android Studio and clicked Next Next Next as you ran it, Android Studio will have already installed
emulator/emulatorthere.Skip Pull Request Checklist:
swift test