Add a Toolbar playground that actually hides all bars#56
Open
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Open
Add a Toolbar playground that actually hides all bars#56dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apropos skiptools/skip-ui#308
The existing "Hide Bars" playground was using the implicit default, which is buggy. skiptools/skip-ui#308 I've renamed the existing playground to "Hide Automatic Bar" (because it's only meant to hide the navigation bar on iOS) and added a new playground that explicitly hides all bars.
Today, "Hide Automatic Bar" hides all bars on Android. After skiptools/skip-ui#309 merges, "Hide Automatic Bar" will only hide the navigation bar.
Either way, the new "Hide Bars" hides all bars on both platforms.
Skip Pull Request Checklist:
swift test