-
-
Notifications
You must be signed in to change notification settings - Fork 19
Remove unneeded SkipUI dependencies #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't repro this locally. I ran |
|
SkipUI is unfortunately needed because that is how we get the current |
|
Why doesn't this build fail on my machine? |
|
Dunno, but it fails for me: |
|
Ugh, yeah, I guess I do see that, but the last part of the output makes it look successful: BUILD SUCCESSFUL in 7s |
SkipFirebaseAuthandSkipFirebaseMessagingwere configured to depend on SkipUI, but they don't use it and don't need it.swift testandskip android buildsucceeds on my machine on this PR.Skip Pull Request Checklist:
swift test