Skip to content

Conversation

@dfabulich
Copy link
Contributor

SkipFirebaseAuth and SkipFirebaseMessaging were configured to depend on SkipUI, but they don't use it and don't need it. swift test and skip android build succeeds on my machine on this PR.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

@cla-bot cla-bot bot added the cla-signed label Oct 8, 2025
@dfabulich
Copy link
Contributor Author

I don't repro this locally. I ran swift package clean && swift test && skip android build and it all passed.

@marcprux
Copy link
Member

marcprux commented Oct 8, 2025

SkipUI is unfortunately needed because that is how we get the current Activity (from UIApplication.shared.androidActivity), which we use in onMessageReceived.

@dfabulich
Copy link
Contributor Author

Why doesn't this build fail on my machine?

@marcprux
Copy link
Member

marcprux commented Oct 8, 2025

Dunno, but it fails for me:

marc@zap skip-firebase % gh pr checkout 53
remote: Enumerating objects: 15, done.
remote: Counting objects: 100% (15/15), done.
remote: Compressing objects: 100% (1/1), done.
remote: Total 8 (delta 7), reused 8 (delta 7), pack-reused 0 (from 0)
Unpacking objects: 100% (8/8), 627 bytes | 89.00 KiB/s, done.
From https://github.com/skiptools/skip-firebase
 * [new ref]         refs/pull/53/head -> remove-unneeded-skipui
Switched to branch 'remove-unneeded-skipui'

marc@zap skip-firebase % swift test
Fetching https://source.skip.tools/skip.git from cache
…

> Task :SkipFirebaseAuth:compileDebugKotlin FAILED
e: file:///opt/src/github/skiptools/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseAuthTests/destination/skipstone/SkipFirebaseAuth/src/main/kotlin/skip/firebase/auth/SkipFirebaseAuth.kt:144:26 Unresolved reference 'UIApplication'.
e: file:///opt/src/github/skiptools/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseAuthTests/destination/skipstone/SkipFirebaseAuth/src/main/kotlin/skip/firebase/auth/SkipFirebaseAuth.kt:144:63 Cannot infer type for this parameter. Specify it explicitly.
e: file:///opt/src/github/skiptools/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseAuthTests/destination/skipstone/SkipFirebaseAuth/src/main/kotlin/skip/firebase/auth/SkipFirebaseAuth.kt:148:71 Argument type mismatch: actual type is 'Any', but 'Activity' was expected.

…lots more output…

@dfabulich
Copy link
Contributor Author

Ugh, yeah, I guess I do see that, but the last part of the output makes it look successful:

BUILD SUCCESSFUL in 7s
147 actionable tasks: 147 executed
JUNIT TEST STDOUT: SkipFirebaseCoreTests:
STDOUT> I/AssetManager: no overlays.list file found
STDOUT> W/PackageParser: Unknown element under : queries at /private/tmp/tp/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseCoreTests/destination/skipstone/SkipFirebaseCore/.build/SkipFirebaseCore/intermediates/apk_for_local_test/debugUnitTest/packageDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #16
STDOUT> W/PackageParser: No actions in intent filter at /private/tmp/tp/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseCoreTests/destination/skipstone/SkipFirebaseCore/.build/SkipFirebaseCore/intermediates/apk_for_local_test/debugUnitTest/packageDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #34
STDOUT> W/PackageParser: No actions in intent filter at /private/tmp/tp/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseCoreTests/destination/skipstone/SkipFirebaseCore/.build/SkipFirebaseCore/intermediates/apk_for_local_test/debugUnitTest/packageDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #42
STDOUT> W/PackageParser: No actions in intent filter at /private/tmp/tp/skip-firebase/.build/plugins/outputs/skip-firebase/SkipFirebaseCoreTests/destination/skipstone/SkipFirebaseCore/.build/SkipFirebaseCore/intermediates/apk_for_local_test/debugUnitTest/packageDebugUnitTestForUnitTest/apk-for-local-test.ap_ Binary XML file line #50
JUNIT TEST STDERR: SkipFirebaseCoreTests:
STDERR> [Robolectric] WARN: Android SDK 36 requires Java 21 (have Java 17). Tests won't be run on SDK 36 unless explicitly requested.
JUNIT TEST PASSED SkipFirebaseCoreTests.testSkipFirebase (0.858)
JUNIT TEST SUITE: SkipFirebaseCoreTests: PASSED 1 FAILED 0 SKIPPED 0 TIME 0.86
JUNIT SUITES 1 TESTS 1 PASSED 1 (100.0%) FAILED 0 SKIPPED 0 TIME 0.86
Completed gradle test run for local
􀟈 Test run started.
􀄵 Testing Library Version: 1085
􀄵 Target Platform: arm64e-apple-macos14.0
􁁛 Test run with 0 tests in 0 suites passed after 0.001 seconds.

image

@dfabulich dfabulich closed this Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants