[PS-22912] fix crash from upgrading to react native 61.5 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erenn16
reviewed
Jun 18, 2020
| @@ -471,7 +471,7 @@ public void setContentOffset(float x, float y) { | |||
| WritableMap contentOffsetMap = Arguments.createMap(); | |||
| contentOffsetMap.putDouble("x", PixelUtil.toDIPFromPixel(contentOffset.x)); | |||
| contentOffsetMap.putDouble("y", PixelUtil.toDIPFromPixel(contentOffset.y)); | |||
| event.putMap("contentOffset", contentOffsetMap); | |||
| event.putMap("contentOffset", (ReadableMap)contentOffsetMap); | |||
There was a problem hiding this comment.
Is this a safe cast? Won't throw an error on its own at some point?
There was a problem hiding this comment.
Yes, it should be a safe cast since WritableMap extends from ReadableMap so any function it calls from ReadableMap should also be implemented by contentOffsetMap. I'm not sure why it doesn't accept the WritableMap in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native 61+ changed the type in putMap to accept a ReadableMap instead of a WritableMap. Casting the argument to WritableMap to fix the crash.