Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Overview #318

Merged
merged 23 commits into from
Feb 27, 2023
Merged

Course Overview #318

merged 23 commits into from
Feb 27, 2023

Conversation

cmwilson21
Copy link
Contributor

Why:

General course update

What's being changed:

Updated images and content

Check off the following:

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@@ -171,14 +195,14 @@ You may have noticed after your commit that a message displayed indicating your
<details id=4>
<summary><h2>Step 4: Merge your pull request</h2></summary>

_Nicely done friend! :sunglasses:_
_Nicely done! :sunglasses:_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll probably see this quite a bit in Skills courses. Learning Lab would be {{ username }} but we didn't have access to that with template repositories, just context.

Copy link
Contributor

@emilyistoofunky emilyistoofunky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmwilson21 These are some great changes, thank you so much! Pinging in @ethanpalm about a video update and I'll also open an internal issue about that.

README.md Outdated
@@ -54,28 +61,40 @@ People use GitHub to build some of the most advanced technologies in the world.

_Welcome to "Introduction to GitHub"! :wave:_

**What is GitHub?**: GitHub is a collaboration platform that uses [Git](https://docs.github.com/get-started/quickstart/github-glossary#git) for versioning. GitHub is a popular place to share and contribute to [open-source](https://docs.github.com/get-started/quickstart/github-glossary#open-source) software.
**What is GitHub?**: GitHub is a collaboration platform that uses _[Git](https://docs.github.com/get-started/quickstart/github-glossary#git)_ for versioning. GitHub is a popular place to share and contribute to [open-source](https://docs.github.com/get-started/quickstart/github-glossary#open-source) software.
<br>:tv: [Video: What is GitHub?](https://www.youtube.com/watch?v=w3jLJU7DT5E)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ethanpalm does https://www.youtube.com/watch?v=pBy1zgt0XPc feel like a good fit to replace this older video with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The humble tractor video 🚜

Yes, I think we should replace the old video with the new https://www.youtube.com/watch?v=pBy1zgt0XPc. It'll be good to have the course content aligned with the current branding and production value considering how many people use it.

1. Make a new public repository with a name that matches your GitHub username.
2. Create a file named `README.md` in its root. The "root" means not inside any folder in your repository.
3. Edit the contents of the `README.md` file.
4. If you created a new branch for your file, open and merge a pull request on your branch.
5. We'd love to see your new profile! Share your profile on social media and tag us!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Good change here.

cmwilson21 and others added 4 commits February 24, 2023 15:51
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
Co-authored-by: Emily Gould <4822039+emilyistoofunky@users.noreply.github.com>
@cmwilson21 cmwilson21 merged commit b8a8d93 into main Feb 27, 2023
@cmwilson21 cmwilson21 deleted the cmwilson21-patch1 branch February 27, 2023 21:33
@tarek295197

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants