Skip to content

Conversation

@jamesmontemagno
Copy link
Contributor

@jamesmontemagno jamesmontemagno commented Sep 11, 2025

Fixes #58

Summary

Changes

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Docker development container configuration to use a more specific Python base image and modifies the Docker-in-Docker feature settings. The changes address issue #58 by specifying the Debian distribution variant and adjusting the container runtime configuration.

  • Updated Python base image to include explicit Debian Bookworm distribution tag
  • Modified Docker-in-Docker feature to disable Moby runtime

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@FidelusAleksander FidelusAleksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did start up the codespace and encountered the error, the PR indeed fixes it

Thanks for this PR @jamesmontemagno !

@FidelusAleksander
Copy link
Contributor

This was probably caused by devcontainers/features#1442

@FidelusAleksander FidelusAleksander merged commit f2031b3 into skills:main Sep 11, 2025
@chriswblake
Copy link
Member

chriswblake commented Sep 11, 2025

I'm actually not sure we need docker-in-docker on this exercise anymore. With the switch to using the GitHub-hosted version of the MCP server in #56, I don't think there is a need to run docker containers.

@FidelusAleksander, we might consider just removing this in a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Does not run in GitHub workspace, Container creation failed

3 participants