fix: update find-exercise workflow to also work on closed issues #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the find-exercise workflow so that it no longer filters only open issues, helping to support bonus step workflows that may run on closed issues.
- Removed the hardcoded "state: 'open'" parameter when listing issues
- The workflow will now include both open and closed issues in its execution
Comments suppressed due to low confidence (1)
.github/workflows/find-exercise-issue.yml:40
- Removing the state filter now allows both open and closed issues to be returned. Please ensure that any subsequent logic in the workflow properly handles issues regardless of their state.
repo: context.repo.repo,
FidelusAleksander
changed the title
|
@chriswblake @arilivigni Do you guys see any problems with this workflow also returning the exercise issue after it is closed? |
arilivigni
approved these changes
Jun 25, 2025
|
No issues from me. I think that is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This could be useful in some occasions, one that I've run into is people completing the Getting Started with Copilot exercise and only after finishing they notice the bonus step.
The bonus step workflow was still enabled, but it would fail because the
find-exerciseworkflow was only looking for open issues.https://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues
Checklist