-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to ClientRequest so we have better control #115
Conversation
fyi @ThisIsMissEm and @rmosolgo I believe this resolves your issues |
"radium": "^0.14.1", | ||
"react": "^15.6.1", | ||
"react-dom": "^15.6.1", | ||
"react-modal": "^2.0.2", | ||
"uuid": "^3.1.0", | ||
"prop-types": "^15.6.0" | ||
"uuid": "^3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
With this change, I'm suddenly seeing an error:
Could you verify that? This was just from making a simple query to |
I don't have time to test this, but the description sounds correct & like it'd fix the issue. |
Ah @gjtorikian yeah looks like thats a problem. Turns out its because I'm using the I would reach out to window and do |
a35d0af
to
d7b0764
Compare
alright @gjtorikian after some digging, I got both http and https requests working, and I brought back the error handling that I unintentionally removed. |
d7b0764
to
e6f9c03
Compare
Great, thank you! Release forthcoming. |
awesome. Thanks for the quick turnaround! |
This PR switches from the isomorphic-fetch library to the native http and https modules to give us more control over request configuration.
The fetch library operates under the assumption its in the browser which means it doesn't allow certain headers to be set like
Host
,Cookie
orUser-Agent
. Since this is an electron app, we don't have the same limitations.I believe this PR will also resolve #112 and close #62
/cc @skevy @gjtorikian