Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,5 @@ linters:
rules:
- name: argument-limit
arguments: [4]
- name: function-result-limit
arguments: [3]
20 changes: 10 additions & 10 deletions cmd/up.go
Original file line number Diff line number Diff line change
Expand Up @@ -661,15 +661,15 @@ func (cmd *UpCmd) devPodUpMachine(
})
}

return sshtunnel.ExecuteCommand(
ctx,
client,
devPodConfig.ContextOption(config.ContextOptionSSHAddPrivateKeys) == "true",
agentInjectFunc,
sshTunnelCmd,
agentCommand,
log,
func(ctx context.Context, stdin io.WriteCloser, stdout io.Reader) (*config2.Result, error) {
return sshtunnel.ExecuteCommand(sshtunnel.ExecuteCommandOptions{
Ctx: ctx,
Client: client,
AddPrivateKeys: devPodConfig.ContextOption(config.ContextOptionSSHAddPrivateKeys) == "true",
AgentInject: agentInjectFunc,
SSHCommand: sshTunnelCmd,
Command: agentCommand,
Log: log,
TunnelServerFunc: func(ctx context.Context, stdin io.WriteCloser, stdout io.Reader) (*config2.Result, error) {
return tunnelserver.RunUpServer(
ctx,
stdout,
Expand All @@ -680,7 +680,7 @@ func (cmd *UpCmd) devPodUpMachine(
log,
)
},
)
})
}

func startJupyterNotebookInBrowser(
Expand Down
20 changes: 10 additions & 10 deletions pkg/devcontainer/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,16 +249,16 @@ func (r *runner) executeSetup(ctx context.Context, result *config.Result, setupC
)
}

return sshtunnel.ExecuteCommand(
ctx,
nil,
false,
agentInjectFunc,
sshTunnelCmd,
setupCommand,
r.Log,
runSetupServer,
)
return sshtunnel.ExecuteCommand(sshtunnel.ExecuteCommandOptions{
Ctx: ctx,
Client: nil,
AddPrivateKeys: false,
AgentInject: agentInjectFunc,
SSHCommand: sshTunnelCmd,
Command: setupCommand,
Log: r.Log,
TunnelServerFunc: runSetupServer,
})
}

func (r *runner) buildSSHTunnelCommand() string {
Expand Down
Loading
Loading