fix(devcontainer/setup): use remoteEnv.PATH as specified in devcontainer.json

[skevetter]

references loft-sh#1366

Signed-off-by: Samuel K skevetter@pm.me

Summary by CodeRabbit

• Refactor

  • Simplified environment variable configuration merging logic by removing specialized handling rules, improving code predictability and maintainability

• Tests

  • Added comprehensive test coverage for environment variable behavior across multiple scenarios, including override mechanics, path ordering, value preservation, and environment integration

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The mergeRemoteEnv function signature was simplified by removing the remoteUser parameter. Complex PATH-specific merge logic was eliminated in favor of straightforward environment variable override behavior. A comprehensive test suite validates the simplified implementation.

Changes

Cohort / File(s)	Summary
Core logic refactoring pkg/devcontainer/setup/lifecyclehooks.go	Function signature of mergeRemoteEnv simplified by removing remoteUser parameter. PATH-specific merge logic removed; implementation now performs straightforward override starting with probedEnv, then applying remoteEnv on top. Unused imports (regexp, slices) removed. Comments updated for RunLifecycleHooks and mergeRemoteEnv.
Test suite for mergeRemoteEnv pkg/devcontainer/setup/lifecyclehooks_test.go	New test file introducing MergeRemoteEnvTestSuite using testify/suite. Tests validate behavior across multiple scenarios: PATH overrides, custom PATH entry ordering, non-PATH variable passthrough, probed PATH fallback, and remote environment precedence.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: simplifying mergeRemoteEnv to use remoteEnv.PATH as specified in devcontainer.json, removing custom PATH merge logic.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}