Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/drawer-smooth-close-animation #2219

Conversation

Mahmoud-zino
Copy link
Contributor

Linked Issue

Closes #2212

Description

The weird behaviour is because of the easing function, fly uses cubicOut as a default value so when the transition enters we get the expected result but when it exits the transition will seem faster.

see https://svelte.dev/examples/easing for visual reference.

Adding easing -> cubicIn when exiting will balance the speed of the transition.

Changsets

Instructions: Changesets automate our changelog. If you modify files in /packages, run pnpm changeset in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should be minor while chores and bugfixes should be patch. Please prefix the changeset message with feat:, bugfix: or chore:.

Checklist

Please read and apply all contribution requirements.

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm ci:check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: 36c5698

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@skeletonlabs/skeleton Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Nov 6, 2023 6:11pm

@endigo9740
Copy link
Contributor

endigo9740 commented Nov 6, 2023

@Mahmoud-zino this looks so much better! Seems good with a quick glance. I'll aim to merge this before the release tomorrow if time allows.

@endigo9740 endigo9740 merged commit 4fe5e62 into skeletonlabs:dev Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drawers not animating smoothly on close
2 participants