Skip to content

Updated svelte dep, fixed test utils being shipped to npm #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Hugos68
Copy link
Collaborator

@Hugos68 Hugos68 commented Jul 2, 2024

Linked Issue

Closes #108

Description

  • Update svelte to latest, no changes were required, but a bunch of bugs were fixed.
  • Updated @testing-library/svelte to latest (see this comment)
  • Removes the test.svelte.ts file (which is a test only utils file) from getting published to npm.

Changesets

We use Changesets to automatically create our changelog per each release. Any changes or additions to the Library assets in /lib must be documented with a new Changeset. This can be done as follows:

  1. Navigate to the root of the project on your feature branch.
  2. Run pnpm changeset to trigger the Changeset CLI.
  3. Follow the instructions when prompted.
    • Changesets should be either minor or patch. Never major.
    • Prefix your Changeset description using: feature:, chore: or bugfix:.
  4. Changeset .md files are added to the /.changeset directory.
  5. Commit and push the the new changeset file.

Checklist

Please read and apply all contribution requirements.

  • PR targets the dev branch (NEVER master)
  • All website documentation is current with your changes
  • Ensure Prettier formatting is current - run pnpm format
  • Ensure ESLint linting is current - run pnpm lint
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 2118f67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 7:28am

@Hugos68 Hugos68 merged commit 3987c5b into dev Jul 2, 2024
7 checks passed
@Hugos68 Hugos68 deleted the patch/dep-update branch July 2, 2024 18:10
Hugos68 added a commit that referenced this pull request Jul 3, 2024
Hugos68 added a commit that referenced this pull request Jul 3, 2024
* Updated svelte and testing deps, fixed test utils being shipped to npm (#132)

* Updated svelte dep, fixed test utils being shipped to npm

* remove unneeded comment

* Added missing changeset for (#132)
Hugos68 added a commit that referenced this pull request Jul 17, 2024
* Updated svelte and testing deps, fixed test utils being shipped to npm (#132)

* Updated svelte dep, fixed test utils being shipped to npm

* remove unneeded comment

* Added missing changeset for (#132)

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test utils are packaged
2 participants