Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vCard: fix validation of N and FN fields to be within the correct range #77

Merged
merged 2 commits into from
Jun 20, 2017

Conversation

tasn
Copy link
Contributor

@tasn tasn commented May 31, 2017

The ranges were wrong according to the spec.

See commits for more info.

tasn added 2 commits May 31, 2017 14:07
According to the spec, there can be either no, or 1 N fields.
Current code limited it to just 1.

Reference: https://tools.ietf.org/html/rfc6350\#section-6.2.2
According to the spec, there can be 1 or more FN fields.
Current code limited it to just 1.

Reference: https://tools.ietf.org/html/rfc6350\#section-6.2.1

Fixes skarim#69
@tasn
Copy link
Contributor Author

tasn commented Jun 13, 2017

Ping

@wpercy wpercy merged commit ef4d034 into skarim:master Jun 20, 2017
@tasn
Copy link
Contributor Author

tasn commented Jun 21, 2017

Thanks!
Looking forward to the next release.

@tasn tasn deleted the limits branch June 21, 2017 17:00
@wpercy wpercy modified the milestone: 0.9.5 Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants